Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3AEB5200D11 for ; Mon, 2 Oct 2017 20:48:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 393561609EF; Mon, 2 Oct 2017 18:48:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 581AA1609C0 for ; Mon, 2 Oct 2017 20:48:28 +0200 (CEST) Received: (qmail 92049 invoked by uid 500); 2 Oct 2017 18:48:25 -0000 Mailing-List: contact user-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@cassandra.apache.org Delivered-To: mailing list user@cassandra.apache.org Received: (qmail 92036 invoked by uid 99); 2 Oct 2017 18:48:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Oct 2017 18:48:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DA7541A5F2B for ; Mon, 2 Oct 2017 18:48:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id BcOwSplzwOw8 for ; Mon, 2 Oct 2017 18:48:23 +0000 (UTC) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9C8A260E09 for ; Mon, 2 Oct 2017 18:48:23 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id e195so8706905wma.5 for ; Mon, 02 Oct 2017 11:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=5xxJ/AcN2CMZKI5SuSjEp4DZ9wtRl1fIpzvzyIhExBE=; b=qFZv8KCS5ALiybkOws7I7BsNWk44k1nDle+rB++ygZXh9/Sqb3mmQMXrsSOxRzaGVa i9Z6fBSktrjh0O2zKIFdnb18EmKQ/4mcHH1StcxodaW549EE0rnA30pPQAtNdayyLCgd 5exRIV1EoFNjY0lHeoOxhqPAumvtKsb7F0guRV0xua8DJ7FPkUWlgL4TsHGNdPn8eou/ vz13tyopNXrkL5TbEKJLXQaTzI1yHmSGXYlIdGhMcX9b/Hg5GReRrwMrmaddpUSiI7es U9lVJt4+odj4ttmJU6Tkw3IQm3JRVaNj/l+BnvLbxMIBrb3R7Vw4uz/lkKUBGk9uGpwK HWtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=5xxJ/AcN2CMZKI5SuSjEp4DZ9wtRl1fIpzvzyIhExBE=; b=Dt7wQzSU1zHZEu6Fm0zzDO7FQSX9IUfIBVOfUgitaLrh5NwrKifTxcxu30yB8oxJpU nDkiaPvHY5ON9sT2zJhujk3KzqC4a4KQ0tjgVtIy34NzfFyGF7EI+CuZ7ekr2i/asmCe j7ZE7atKkXv5GDMvzaUM1Y3Gi3oezOGRYVN42XmwIQKFGphBBmEyKafbZqhLKXoAl+CT m3PoYeBeUreDgXhEDZhyNS8Ic6FM+SGlCK0PU9GlyNwf/zAvhoquXpeGh0t+fJRoiT8w CrffWWnlfiQVjVpHcJNtGaVGd/CKdeIapym1GEpY0DjXQEEumFUSzJsbOHNzobAYvd5K Ukdw== X-Gm-Message-State: AHPjjUjb9V3xiUbIuvjL67tq7W1auuWZtjSdFS5A5saGGZSx6TyT7OB3 fq8uMNbYu4JU2N6gGjqEkbBICLkelc63Qozsffm9Ig== X-Google-Smtp-Source: AOwi7QBoJl2Y3068IUPYdS52qjgCAXzpqO80PiBSbzDmJMpTBiMZ+bqrkClmQHB+5Oyu4HqXTWx8sS+i00psi3NQV+8= X-Received: by 10.80.182.7 with SMTP id b7mr20822682ede.61.1506970102511; Mon, 02 Oct 2017 11:48:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.194.74 with HTTP; Mon, 2 Oct 2017 11:48:02 -0700 (PDT) In-Reply-To: References: <1489C17A-C465-42B4-A4D2-862886BC5E66@gmail.com> From: Jeff Jirsa Date: Mon, 2 Oct 2017 11:48:02 -0700 Message-ID: Subject: Re: To: cassandra Content-Type: multipart/alternative; boundary="94eb2c0e45b4a5bcc5055a94d19b" archived-at: Mon, 02 Oct 2017 18:48:29 -0000 --94eb2c0e45b4a5bcc5055a94d19b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable You're right, sorry I didnt read the full stack (gmail hid it from me) Would you open a JIRA with your stack traces, and note (somewhat loudly) that this is a regression? On Mon, Oct 2, 2017 at 11:43 AM, Dan Kinder wrote: > Right, I just meant that calling it at all results in holding a read lock= , > which unfortunately is blocking these read threads. > > On Mon, Oct 2, 2017 at 11:40 AM, Jeff Jirsa wrote: > >> >> >> On Mon, Oct 2, 2017 at 11:27 AM, Dan Kinder wrote= : >> >>> (As a side note, it seems silly to call shouldDefragment at all on a >>> read if the compaction strategy is not STSC) >>> >>> >>> >> It defaults to false: >> >> https://github.com/apache/cassandra/blob/cassandra-3.0/src/ >> java/org/apache/cassandra/db/compaction/AbstractCompactionS >> trategy.java#L302 >> >> And nothing else other than STCS overrides it to true. >> >> >> > > > -- > Dan Kinder > Principal Software Engineer > Turnitin =E2=80=93 www.turnitin.com > dkinder@turnitin.com > --94eb2c0e45b4a5bcc5055a94d19b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You're right, sorry I didnt read the full stack (gmail= hid it from me)

Would you open a JIRA with your stack t= races, and note (somewhat loudly) that this is a regression?=C2=A0


On Mon, Oct 2, 2017 at 11:43 AM, Dan Kinder <dkinder@turnitin.com= > wrote:
Right= , I just meant that calling it at all results in holding a read lock, which= unfortunately is blocking these read threads.

On Mon, Oct 2, 20= 17 at 11:40 AM, Jeff Jirsa <jjirsa@gmail.com> wrote:

<= br>
On Mon, Oct 2, 2017 at 11:27 AM, Dan Ki= nder <dkinder@turnitin.com> wrote:
(As a side note, it seems= silly to call shouldDefragment at all on a read if the compaction strategy= is not STSC)



It defaults to fa= lse:

=C2=A0
And nothing else other than STCS overrides it to true.




--
Dan Ki= nder
Principal Software Engineer
Turnitin =E2=80=93 www.turnitin.com
dkinder@turnitin.com

--94eb2c0e45b4a5bcc5055a94d19b--