cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] aweisberg commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should never prefer latent replicas
Date Fri, 22 Mar 2019 23:29:59 GMT
aweisberg commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch
should never prefer latent replicas
URL: https://github.com/apache/cassandra/pull/283#discussion_r267997785
 
 

 ##########
 File path: test/unit/org/apache/cassandra/locator/DynamicEndpointSnitchTest.java
 ##########
 @@ -262,8 +298,13 @@ public void testLatencyProbeNeeded()
         assertEquals(0, measurements.get(hosts[4]).nextProbeDelayMillis);
 
         // And now we put one of those non requested hosts down in gossip and ensure it's
cleaned out of samples
+        VersionedValue.VersionedValueFactory valueFactory;
+        valueFactory = new VersionedValue.VersionedValueFactory(DatabaseDescriptor.getPartitioner());
+
         assertTrue(measurements.containsKey(hosts[3]));
-        Gossiper.instance.markDead(hosts[3], Gossiper.instance.getEndpointStateForEndpoint(hosts[3]));
+        // mark the node as removed
+        Gossiper.instance.injectApplicationState(hosts[3], ApplicationState.STATUS_WITH_PORT,
 
 Review comment:
   Just curious why this had to change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message