From pr-return-1572-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org  Mon Nov  5 19:42:19 2018
Return-Path: <pr-return-1572-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id BA622180670
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  5 Nov 2018 19:42:18 +0100 (CET)
Received: (qmail 51385 invoked by uid 500); 5 Nov 2018 18:42:17 -0000
Mailing-List: contact pr-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:pr-help@cassandra.apache.org>
List-Unsubscribe: <mailto:pr-unsubscribe@cassandra.apache.org>
List-Post: <mailto:pr@cassandra.apache.org>
List-Id: <pr.cassandra.apache.org>
Reply-To: pr@cassandra.apache.org
Delivered-To: mailing list pr@cassandra.apache.org
Received: (qmail 51373 invoked by uid 99); 5 Nov 2018 18:42:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Nov 2018 18:42:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 23470DFD43; Mon,  5 Nov 2018 18:42:17 +0000 (UTC)
From: jolynch <git@git.apache.org>
To: pr@cassandra.apache.org
Reply-To: pr@cassandra.apache.org
References: <git-pr-277-cassandra@git.apache.org>
In-Reply-To: <git-pr-277-cassandra@git.apache.org>
Subject: [GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...
Content-Type: text/plain
Message-Id: <20181105184217.23470DFD43@git1-us-west.apache.org>
Date: Mon,  5 Nov 2018 18:42:17 +0000 (UTC)

Github user jolynch commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/277#discussion_r230865112
  
    --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java ---
    @@ -307,6 +320,55 @@ public static void setViewRemoved(String keyspaceName, String viewName)
             forceBlockingFlush(VIEW_BUILD_STATUS);
         }
     
    +    /**
    +     * Reads blacklisted partitions from system_distributed.blacklisted_partitions table.
    +     * Stops reading partitions upon exceeding the cache size limit by logging a warning.
    +     * @return
    +     */
    +    public static Set<BlacklistedPartition> getBlacklistedPartitions()
    +    {
    +        String query = "SELECT keyspace_name, columnfamily_name, partition_key FROM %s.%s";
    +        UntypedResultSet results;
    +        try
    +        {
    +            results = QueryProcessor.execute(format(query, SchemaConstants.DISTRIBUTED_KEYSPACE_NAME, BLACKLISTED_PARTITIONS),
    --- End diff --
    
    I think there is a local execution with pagination option (which should avoid oom right)?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org