cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jolynch <...@git.apache.org>
Subject [GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...
Date Mon, 05 Nov 2018 18:42:17 GMT
Github user jolynch commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/277#discussion_r230865112
  
    --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java ---
    @@ -307,6 +320,55 @@ public static void setViewRemoved(String keyspaceName, String viewName)
             forceBlockingFlush(VIEW_BUILD_STATUS);
         }
     
    +    /**
    +     * Reads blacklisted partitions from system_distributed.blacklisted_partitions table.
    +     * Stops reading partitions upon exceeding the cache size limit by logging a warning.
    +     * @return
    +     */
    +    public static Set<BlacklistedPartition> getBlacklistedPartitions()
    +    {
    +        String query = "SELECT keyspace_name, columnfamily_name, partition_key FROM %s.%s";
    +        UntypedResultSet results;
    +        try
    +        {
    +            results = QueryProcessor.execute(format(query, SchemaConstants.DISTRIBUTED_KEYSPACE_NAME,
BLACKLISTED_PARTITIONS),
    --- End diff --
    
    I think there is a local execution with pagination option (which should avoid oom right)?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message