cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #191: 13993
Date Wed, 14 Feb 2018 14:16:55 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/191#discussion_r168186136
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection(InetAddressAndPort
address)
             }
             return true;
         }
    +
    +    public void blockForPeers()
    +    {
    +        // TODO make these yaml props?
    +        int alivePercent = Integer.getInteger(Config.PROPERTY_PREFIX + "blockForPeers.percent",
70);
    +        if (alivePercent < 0)
    --- End diff --
    
    This is fair, but I felt that giving *some* upper bound didn't seem unreasonable. Should
we really delay starting the process by an extra order of magnitude just because an operator
added an extra zero to the configuration? I understand your point about least surprise, but
that might be beyond the spirit of this ticket. wdyt?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message