cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From josh-mckenzie <...@git.apache.org>
Subject [GitHub] cassandra pull request #191: 13993
Date Thu, 08 Feb 2018 18:57:01 GMT
Github user josh-mckenzie commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/191#discussion_r167033937
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -254,6 +258,8 @@ public long getTimeout()
                     return DatabaseDescriptor.getRangeRpcTimeout();
                 }
             },
    +        PING(),
    --- End diff --
    
    Left a similar comment on ticket, but this should be added at the end:
    *** 
    // remember to add new verbs at the end, since we serialize by ordinal
            UNUSED_1,
            UNUSED_2,
            UNUSED_3,
            UNUSED_4,
            UNUSED_5,



---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message