cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #191: 13993
Date Thu, 08 Feb 2018 18:14:47 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/191#discussion_r167016420
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -254,6 +258,8 @@ public long getTimeout()
                     return DatabaseDescriptor.getRangeRpcTimeout();
                 }
             },
    +        PING(),
    --- End diff --
    
    Should this go this early in the enum before USUED_* and company? Does it make sense to
ever insert anything into the middle of the enum?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message