cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] cassandra pull request #164: Replace the keySet iterator with an entrySet it...
Date Thu, 12 Oct 2017 20:46:17 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/cassandra/pull/164

    Replace the keySet iterator with an entrySet iterator.

    The current source code accesses the value of the Map entry, using a key that is retrieved
from a keySet iterator.
    It is more efficient to use an iterator on the entrySet of the Map, to avoid the Map.get(key)
lookup.
    http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/cassandra master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----
commit e3a1467a82529de26b24de268d3d788874cd0852
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-12T20:43:22Z

    Replace the keySet iterator with an entrySet iterator.
    
    The current source code accesses the value of the Map entry, using a key that is retrieved
from a keySet iterator.
    It is more efficient to use an iterator on the entrySet of the Map, to avoid the Map.get(key)
lookup.
    http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message