cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joaquincasares <...@git.apache.org>
Subject [GitHub] cassandra pull request #159: Fix a few possible metrics.rst bugs
Date Wed, 04 Oct 2017 20:46:10 GMT
GitHub user joaquincasares opened a pull request:

    https://github.com/apache/cassandra/pull/159

    Fix a few possible metrics.rst bugs

    I was trying to implement a Prometheus exporter with 2.2, but ran into a few issues.
    
    I did check the source and it seems as though 3.0 matches 2.2 for these specific edits.
    
    The path/scope ordering was needed to allow Prometheus to export correctly.
    
    https://github.com/apache/cassandra/blob/9a47974d6378b62dd2cdb2d3e509374b002caa2c/src/java/org/apache/cassandra/metrics/ThreadPoolMetrics.java#L117
    
    Although it sounds weird, it seems as though DroppedMessages is now DroppedMessage.
    
    https://github.com/apache/cassandra/blob/9a47974d6378b62dd2cdb2d3e509374b002caa2c/src/java/org/apache/cassandra/metrics/DroppedMessageMetrics.java#L43
    
    I was, however, unsure where to check on the `Metric Name` portion and just looked at
the MBean code referenced above.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joaquincasares/cassandra metrics-rst-ninja-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit 18c50540c80dc9ec11b50badc6bbcf45ca3748d9
Author: Joaquin Casares <joaquin@thelastpickle.com>
Date:   2017-10-04T20:42:05Z

    Fix a few possible metrics.rst bugs

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message