cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeffjirsa <...@git.apache.org>
Subject [GitHub] cassandra issue #100: clean up
Date Mon, 27 Mar 2017 03:00:55 GMT
Github user jeffjirsa commented on the issue:

    https://github.com/apache/cassandra/pull/100
  
    This pull request is unlikely to be merged in it's current state. These changes seem scattered
- there are a lot of asserts in the form that you changed, and a lot of comments in the form
you changed, but you've only changed one of each, and they appear unrelated. It also has an
unnecessary empty file (.toDelete), which we wouldn't want to merge.
    
    Finally, we really prefer JIRA tickets for non-trivial changes. I encourage you to close
this pull request, as the project can not close it for you. Please see http://cassandra.apache.org/doc/latest/development/patches.html
for details.  
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message