cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Haddad <...@jonhaddad.com>
Subject Re: Testing and jira tickets
Date Thu, 09 Mar 2017 19:56:12 GMT
No problem, I'll start a new thread.

On Thu, Mar 9, 2017 at 11:48 AM Jason Brown <jasedbrown@gmail.com> wrote:

> Jon and Brandon,
>
> I'd actually like to narrow the discussion, and keep it focused to my
> original topic. Those are two excellent topics that should be addressed,
> and the solution(s) might be the same or similar as the outcome of this.
> However, I feel they deserve their own message thread.
>
> Thanks for understanding,
>
> -Jason
>
> On Thu, Mar 9, 2017 at 11:27 AM, Brandon Williams <driftx@gmail.com>
> wrote:
>
> > Let me further broaden this discussion to include github branches, which
> > are often linked on tickets, and then later deleted.  This forces a
> person
> > to search through git to actually see the patch, and that process can be
> a
> > little rough (especially since we all know if you're gonna make a typo,
> > it's going to be in the commit, and it's probably going to be the ticket
> > number.)
> >
> > On Thu, Mar 9, 2017 at 1:00 PM, Jonathan Haddad <jon@jonhaddad.com>
> wrote:
> >
> > > If you don't mind, I'd like to broaden the discussion a little bit to
> > also
> > > discuss performance related patches.  For instance, CASSANDRA-13271
> was a
> > > performance / optimization related patch that included *zero*
> information
> > > on if there was any perf improvement or a regression as a result of the
> > > change, even though I've asked twice for that information.
> > >
> > > In addition to "does this thing break anything" we should be asking
> "how
> > > does this patch affect performance?" (and were the appropriate docs
> > > included, but that's another topic altogether)
> > >
> > > On Thu, Mar 9, 2017 at 10:51 AM Jason Brown <jasedbrown@gmail.com>
> > wrote:
> > >
> > > > Hey all,
> > > >
> > > > A nice convention we've stumbled into wrt to patches submitted via
> Jira
> > > is
> > > > to post the results of unit test and dtest runs to the ticket (to
> show
> > > the
> > > > patch doesn't break things). Many contributors have used the
> > > > DataStax-provided cassci system, but that's not the best long term
> > > > solution. To that end, I'd like to start a conversation about what is
> > the
> > > > best way to proceed going forward, and then add it to the "How to
> > > > contribute" docs.
> > > >
> > > > As an example, should contributors/committers run dtests and unit
> tests
> > > on
> > > > *some* machine (publicly available or otherwise), and then post those
> > > > results to the ticket? This could be a link to a build system, like
> > what
> > > we
> > > > have with cassci, or just  upload the output of the test run(s).
> > > >
> > > > I don't have any fixed notions, and am looking forward to hearing
> > other's
> > > > ideas.
> > > >
> > > > Thanks,
> > > >
> > > > -Jason
> > > >
> > > > p.s. a big thank you to DataStax for providing the cassci system
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message