Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
MIME-Version: 1.0
In-Reply-To: <f540f647-0174-9dcb-8fc7-7ceaf403b2b9@mebigfatguy.com>
References: <CAENxBwwXQvq3cGKVqQkQFkeF00S4nc=QfvbZ5CqqFUakcdxLXg@mail.gmail.com>
 <F8D190FB-9639-4CE1-8061-4CEAF8FBB69F@internalcircle.com> <CAENxBww=4OjsWD25ZeY1TubJgnpsW1NtYaSJA7f5xhXAoYNW=g@mail.gmail.com>
 <0BFC983D-518E-4CE2-B4EE-BD369068E1A5@internalcircle.com> <CAENxBwy+rnogxLJD=Dabioi0QaTvz00gbjFta1r1=DXr9PF01Q@mail.gmail.com>
 <7968A06F-863D-4682-A838-B6654E46A208@internalcircle.com> <CABNXB2CL=7L1UwUXKtWmsTi+Tb+L3OUoYO4XAVCkMFhSLx5fWg@mail.gmail.com>
 <CABxe4TqLi7UuXPyHMuh472LDTcgcws6T=LSgedNH2QMNYQPLsw@mail.gmail.com> <f540f647-0174-9dcb-8fc7-7ceaf403b2b9@mebigfatguy.com>
From: Benjamin Lerer <benjamin.lerer@datastax.com>
Date: Thu, 22 Sep 2016 13:29:50 +0200
Message-ID: <CABxe4Tp1o+=zjyXA0C_jrv+VDr6BZM4t1H7N5de8F5xXhi7BfA@mail.gmail.com>
Subject: Re: Question on assert
To: dev@cassandra.apache.org
Content-Type: multipart/alternative; boundary=001a114a966ee6b8b6053d16fa9b
archived-at: Thu, 22 Sep 2016 11:29:58 -0000

--001a114a966ee6b8b6053d16fa9b
Content-Type: text/plain; charset=UTF-8

I fully agree.

On Thu, Sep 22, 2016 at 11:57 AM, Dave Brosius <dbrosius@mebigfatguy.com>
wrote:

> As an aside, C* for some reason heavily uses asserts in unit tests, which
> adds to the "can't see the forest for the trees" problem. I see no reason
> for that. they should all be moved over to junit asserts.
>
>
>
> On 09/22/2016 03:52 AM, Benjamin Lerer wrote:
>
>> We can spend hours arguing about assert vs exceptions. I have seen it
>> happen in every company I worked for.
>> Overall, based on the patches I have reviewed, it seems to me that in
>> general people are using them only has internal safety checks.
>> Unfortunatly, the code change and we can miss things.
>> If anybody think that some SPECIFIC assertions should be replaced by some
>> real checks, I think the best way to do it is to open a JIRA ticket to
>> raise the problem.
>>
>>
>

--001a114a966ee6b8b6053d16fa9b--