cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Lerer <benjamin.le...@datastax.com>
Subject Re: Typo in CommitLog.java: maxiumum s.b. maximum
Date Mon, 11 Apr 2016 07:20:33 GMT
Hi Jack,

Thanks for reporting the problem. I will fix it.

Benjamin

On Sun, Apr 10, 2016 at 10:10 PM, Jack Krupansky <jack.krupansky@gmail.com>
wrote:

> I was baffled why I couldn't find a user's reported log message of
> "Mutation 32MB too large for maximum size of 16Mb" even when I searched
> GitHub for "too large for maximum size". The reason my search failed was
> that the user (or their email client) must have corrected the typo in the
> message that the code actually produces - the code has the text "too large
> for the maxiumum size", when "maxiumum" should be "maximum".
>
> In CommitLog.java, the current code in the add method in trunk:
>
>         if (totalSize > MAX_MUTATION_SIZE)
>         {
>             throw new IllegalArgumentException(String.format("Mutation of
> %s is too large for the maxiumum size of %s",
>
>  FBUtilities.prettyPrintMemory(totalSize),
>
>  FBUtilities.prettyPrintMemory(MAX_MUTATION_SIZE)));
>         }
>
> The corrected code:
>
>         if (totalSize > MAX_MUTATION_SIZE)
>         {
>             throw new IllegalArgumentException(String.format("Mutation of
> %s is too large for the maximum size of %s",
>
>  FBUtilities.prettyPrintMemory(totalSize),
>
>  FBUtilities.prettyPrintMemory(MAX_MUTATION_SIZE)));
>         }
>
> -- Jack Krupansky
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message