Return-Path: X-Original-To: apmail-cassandra-dev-archive@www.apache.org Delivered-To: apmail-cassandra-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D2F3D4B8 for ; Mon, 30 Jul 2012 14:48:32 +0000 (UTC) Received: (qmail 70953 invoked by uid 500); 30 Jul 2012 14:48:31 -0000 Delivered-To: apmail-cassandra-dev-archive@cassandra.apache.org Received: (qmail 70874 invoked by uid 500); 30 Jul 2012 14:48:31 -0000 Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list dev@cassandra.apache.org Received: (qmail 70866 invoked by uid 99); 30 Jul 2012 14:48:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2012 14:48:31 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of edlinuxguru@gmail.com designates 209.85.213.44 as permitted sender) Received: from [209.85.213.44] (HELO mail-yw0-f44.google.com) (209.85.213.44) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2012 14:48:25 +0000 Received: by yhq56 with SMTP id 56so5295288yhq.31 for ; Mon, 30 Jul 2012 07:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=ph4OajPSBy5VQgaq4Wa0BL1lzCAIvlNADVEsBs9bko0=; b=vROPoBhNWRpjBa0n+rdRxtt1tTheCfcF3YhGwL0RQqn+Adb8vWXhw5aVFOvproF/Oa 0QdkHAwTO04ifQkSP3+xda8Z1C4RQXcpEmIM8hgcWZepO8N6z8u9uMHAuTqErkvif7vu wu40CtSb/Nn010Ya6oHk/DjQqRDUHMaYdYUISWerVxFsfbOnXMj5RObYOm1Fgg+gaQ06 GRn/gU76wMqUP5XmBslI4Wp9FpmG9DC1NYk635SsG9njQsrQm2ceWNkBS1U8J6mmut3c gp7Tt8xiYCmHT7QE2C8GugOsnpfpDmG1dfp0r7QYjr10+EaS7LecGvRbUhtIxUYUfKTB BbTg== MIME-Version: 1.0 Received: by 10.50.236.97 with SMTP id ut1mr8451993igc.50.1343659671546; Mon, 30 Jul 2012 07:47:51 -0700 (PDT) Received: by 10.64.102.196 with HTTP; Mon, 30 Jul 2012 07:47:51 -0700 (PDT) In-Reply-To: <50169AE3.9050604@filez.com> References: <500C0FD5.7020406@filez.com> <500CFF9E.5060306@filez.com> <056051B0-156B-4EA9-8694-E408ECD01D6F@yahoo.com> <500DCC91.4060100@filez.com> <50169AE3.9050604@filez.com> Date: Mon, 30 Jul 2012 10:47:51 -0400 Message-ID: Subject: Re: findbugs From: Edward Capriolo To: dev@cassandra.apache.org Content-Type: text/plain; charset=ISO-8859-1 I am sure no one would have an issue with an optional findbugs target. On Mon, Jul 30, 2012 at 10:32 AM, Radim Kolar wrote: > was any decision about findbugs made? you do not consider code style > recommended by findbugs as good practice which should be followed? > > I can submit few findbugs patches, but it will probably turns into flamewar > WE vs FINDBUGS like there: > https://issues.apache.org/jira/browse/HADOOP-8619 > > findbugs problems are pretty easy to fix and there are just 70 of them, it > could be done in two days. > > I do not care about findbugs+cas-dev issue much because i need to fork > cassandra anyway to get performance patches there. Its just matter of > schedule for me if 1 should feed you fb patches before i fork it.