Mailing-List: contact cassandra-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of edward.ribeiro@gmail.com
 designates 209.85.217.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=YmBSXjFaa59EtsdbgCRxnXBSHoLnNOp4bjE2iBIhOLZ8tUYiUspgkfscKdHZtp/oss
         HBf8DwVE+uWvqScfBQUzUCyE6Nmr6zl66nke/MrQSNW7ee6pt4KXgSQ5/U/ddrL4ZA3v
         DwYJTIA29edKJka4vGNCdRqSy6YzqTr0+Qoik=
MIME-Version: 1.0
In-Reply-To: <e06563880906161745t4c37f090qb241fefb82012f65@mail.gmail.com>
References: <123dcca0906161731t3894f054n128a0115964ddee4@mail.gmail.com>
	 <e06563880906161745t4c37f090qb241fefb82012f65@mail.gmail.com>
Date: Tue, 16 Jun 2009 21:51:52 -0300
Message-ID: <123dcca0906161751n77370b38r7e8e607ee6164faa@mail.gmail.com>
Subject: Re: Column assert
From: Edward Ribeiro <edward.ribeiro@gmail.com>
To: cassandra-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

That's alright.

Edward

On Tue, Jun 16, 2009 at 9:45 PM, Jonathan Ellis<jbellis@gmail.com> wrote:
> checking user input is done with explicit if statements; verifying
> internal assumptions is done with asserts. =A0Column is not a
> user-facing class (that would be column_t).
>
> -Jonathan
>
> On Tue, Jun 16, 2009 at 7:31 PM, Edward Ribeiro<edward.ribeiro@gmail.com>=
 wrote:
>> =A0 Dear developers,
>>
>> =A0 I saw the following piece of the code in the Column class:
>>
>> =A0 =A0Column(String name, byte[] value, long timestamp, boolean isDelet=
ed)
>> =A0 =A0{
>> =A0 =A0 =A0 =A0assert name !=3D null;
>> =A0 =A0 =A0 =A0assert value !=3D null;
>> =A0 =A0 =A0 =A0[ ... ]
>> =A0 =A0}
>>
>> Well, the assert is a debug facility and it should not be used in
>> production code, because it only throws an exception when the code is
>> run with the -ea switch. There are other classes that follow the same
>> behaviour in Cassandra code base. If this is being used in place of a
>> null checking "if" statement then I would be glad to submit a couple
>> of patches to fix that.
>>
>> By the way, I saw that Cassandra project currently uses the very good
>> google collections library. Therefore, the code can become even more
>> succint like:
>>
>> import static com.google.common.base.Preconditions.*;
>>
>> [...]
>>
>> =A0 =A0Column(String name, byte[] value, long timestamp, boolean isDelet=
ed)
>> =A0 =A0{
>> =A0 =A0 =A0 =A0 =A0assertNotNull(name,"Column name cannot be null!");
>> =A0 =A0 =A0 =A0 =A0assertNotNull(value, "Byte array cannot be null!");
>> =A0 =A0 =A0 =A0 =A0[...]
>> =A0 =A0 }
>>
>> Best regards,
>> Edward
>>
>