Mailing-List: contact cassandra-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of edward.ribeiro@gmail.com
 designates 74.125.46.153 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=v4s7/x/CHv/9flrq4ZlqXA7U5N4sBQ8JjXDkjICI5RZ5xN5t8g7EHNQ0AmFo7RKqG9
         fObfjNAtoIDc6j2wDDwPn5NN+5hV//bcX3OGLf6toipZTgiQrkYoMgohf74bKZZ4JOS3
         Q70U8c/SORBH6pbYVfsZWq5UnclmycJFE6TIE=
MIME-Version: 1.0
Date: Tue, 16 Jun 2009 21:31:23 -0300
Message-ID: <123dcca0906161731t3894f054n128a0115964ddee4@mail.gmail.com>
Subject: Column assert
From: Edward Ribeiro <edward.ribeiro@gmail.com>
To: cassandra-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

   Dear developers,

   I saw the following piece of the code in the Column class:

    Column(String name, byte[] value, long timestamp, boolean isDeleted)
    {
        assert name != null;
        assert value != null;
        [ ... ]
    }

Well, the assert is a debug facility and it should not be used in
production code, because it only throws an exception when the code is
run with the -ea switch. There are other classes that follow the same
behaviour in Cassandra code base. If this is being used in place of a
null checking "if" statement then I would be glad to submit a couple
of patches to fix that.

By the way, I saw that Cassandra project currently uses the very good
google collections library. Therefore, the code can become even more
succint like:

import static com.google.common.base.Preconditions.*;

[...]

    Column(String name, byte[] value, long timestamp, boolean isDeleted)
    {
          assertNotNull(name,"Column name cannot be null!");
          assertNotNull(value, "Byte array cannot be null!");
          [...]
     }

Best regards,
Edward