Mailing-List: contact cassandra-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-Id: <23048D59-145B-4BB5-B58C-038C42F81474@Holsman.net>
From: Ian Holsman <ian@holsman.net>
To: cassandra-dev@incubator.apache.org
In-Reply-To: <e06563880904021921t14d0c3a5k48ccc4f07e5c7613@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Subject: Re: Random Checkins
Date: Fri, 3 Apr 2009 13:52:10 +1100
References: <a06de5520904021552h4b0922a9xc44e2279fd7e850@mail.gmail.com>
 <a06de5520904021637u50aaf1alc46ea78b8a415213@mail.gmail.com>
 <e06563880904021921t14d0c3a5k48ccc4f07e5c7613@mail.gmail.com>


ideally the test cases that your working with could be made public,  
but until then is it possible for you to run a hudson like service  
inside of FB and mail the test result output to the list so people  
know that tests are failing.

On 03/04/2009, at 1:21 PM, Jonathan Ellis wrote:

> On Thu, Apr 2, 2009 at 6:37 PM, Avinash Lakshman
> <avinash.lakshman@gmail.com> wrote:
>> Another issue with ConcurrentHashMap is that the dude is a memory  
>> hog. We
>> got rid of it over a year ago because of the very same reason.
>
> Re CHM: what do you suggest instead?  I assume you are talking about
> for EfficientBidiMap.  Do you want the Getter to return a copy of the
> ColumnFamily and stick with non-concurrent structures?  Or use
> NonBlockingHashMap?
>
>> Also for
>> everything that is done there is a reason.
>
> I don't see any harm in, for instance, me making a commit, you saying
> "ConcurrentHashMap is a memory hog", and me saying, "okay, what do you
> suggest instead?"  Nothing wrong with post-commit review in trunk.
>
>> I think we are not asking for
>> much to apart from run it by someone before what are basically  
>> changes that
>> suit your style.
>
> We've tried waiting for you or Prashant to review things.  That didn't
> work over on the code.google project and it hasn't worked here.  My
> remove patches sat unreviewed for weeks, literally.  More recently, a
> request for a list of known issues and my attempt to start  a
> conversation about a roadmap have gone without comment so far.
>
> I'm not trying to dump on you; we know you're busy.  But we have
> deadlines too and we can't hold every patch waiting days or weeks for
> a review.
>
> Tell you what.  I will try to get changes reviewed by someone in the
> community before committing.  We will see how that works.  That should
> at least give you some confidence that it's not just me off being a
> cowboy.
>
> -Jonathan

--
Ian Holsman
Ian@Holsman.net