cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Sorokoumov (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-15985) python dtest TestCqlsh added enable_scripted_user_defined_functions which breaks on 2.2
Date Wed, 13 Jan 2021 19:31:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264377#comment-17264377
] 

Aleksandr Sorokoumov edited comment on CASSANDRA-15985 at 1/13/21, 7:30 PM:
----------------------------------------------------------------------------

|Branch||Source||
|2.2|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...Gerrrr:15985-2.2]|
|dtests|[branch|https://github.com/apache/cassandra-dtest/compare/trunk...Gerrrr:CASSANDRA-15985]|

These changes fix the Invalid yaml error as well as TestCqlsh#test_pycodestyle_compliance.

There are still 2 kinds of test failures left in test_cqlsh.py:

 * [TestCqlsh#test_unicode_invalid_request_error|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L533],
[TestCqlsh#test_unicode_syntax_error|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L516],
[TestCqlLogin#test_login_rejects_bad_pass|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L2459],
[TestCqlLogin#test_login_allows_bad_pass_and_continued_use|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L2503].
These tests fail because cassandra 2.2 does not throw ToolError, although the requests return
correct error messages.
 *  [TestCqlsh#test_describe_functions|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L869],
[TestCqlsh#test_describe_types|https://github.com/apache/cassandra-dtest/blob/6d9209e21cd13d5ee0317e9647ec851df1de465e/cqlsh_tests/test_cqlsh.py#L962].
They fail because DESCRIBE in 2.2 does not add a semicolon at the end of the statement.

Both of them require changes in behavior and as 2.2 is marked as for Critical bug fixes only,
I was not sure how we want to approach them. I can either adapt the tests to verify current
behavior or actually fix it. WDYT [~dcapwell]?


was (Author: gerrrr):
|Branch||Source||
|2.2|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...Gerrrr:15985-2.2]|
|dtests|[branch|https://github.com/apache/cassandra-dtest/compare/trunk...Gerrrr:CASSANDRA-15985]|

These changes fix the Invalid yaml error as well as TestCqlsh#test_pycodestyle_compliance.

There are still 2 kinds of test failures left in test_cqlsh.py:

    TestCqlsh#test_unicode_invalid_request_error, TestCqlsh#test_unicode_syntax_error, TestCqlLogin#test_login_rejects_bad_pass,
TestCqlLogin#test_login_allows_bad_pass_and_continued_use. These tests fail because cassandra
2.2 does not throw ToolError, although the requests return correct error messages.
    TestCqlsh#test_describe_functions, TestCqlsh#test_describe_types. They fail because DESCRIBE
in 2.2 does not add a semicolon at the end of the statement.

Both of them require changes in behavior and as 2.2 is marked as for Critical bug fixes only,
I was not sure how we want to approach them. I can either adapt the tests to verify current
behavior or actually fix it. WDYT [~dcapwell]?

> python dtest TestCqlsh added enable_scripted_user_defined_functions which breaks on 2.2
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15985
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: David Capwell
>            Assignee: Aleksandr Sorokoumov
>            Priority: Normal
>             Fix For: 2.2.x
>
>
> {code}
> ERROR [main] 2020-07-26 03:03:14,108 CassandraDaemon.java:744 - Exception encountered
during startup
> org.apache.cassandra.exceptions.ConfigurationException: Invalid yaml. Please remove properties
[enable_scripted_user_defined_functions] from your cassandra.yaml
> 	at org.apache.cassandra.config.YamlConfigurationLoader$MissingPropertiesChecker.check(YamlConfigurationLoader.java:146)
~[main/:na]
> 	at org.apache.cassandra.config.YamlConfigurationLoader.loadConfig(YamlConfigurationLoader.java:113)
~[main/:na]
> 	at org.apache.cassandra.config.YamlConfigurationLoader.loadConfig(YamlConfigurationLoader.java:85)
~[main/:na]
> 	at org.apache.cassandra.config.DatabaseDescriptor.loadConfig(DatabaseDescriptor.java:151)
~[main/:na]
> 	at org.apache.cassandra.config.DatabaseDescriptor.<clinit>(DatabaseDescriptor.java:133)
~[main/:na]
> 	at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:604) [main/:na]
> 	at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:731) [main/:na]]
> {code}
> This test doesn’t put a version limit, so all tests fail on 2.2 since the property
was added to all clusters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message