cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ekaterina Dimitrova (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-15897) Dropping compact storage with 2.1-sstables on disk make them unreadable
Date Wed, 02 Dec 2020 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241928#comment-17241928
] 

Ekaterina Dimitrova edited comment on CASSANDRA-15897 at 12/2/20, 12:42 AM:
----------------------------------------------------------------------------

Patch rebased [here|https://github.com/ekaterinadimitrova2/cassandra/pull/79].  CI run can
be found [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152].

There was a collision between this patch  and CASSANDRA-16228 in [Tracker.java |#diff-9baecde49b36a386d6200cb163d482dd70a816019ba2b45f0ff25c3ca4eabf28L184]

To solve It I added a new flag [updatingSize|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:15897-3.0#diff-9baecde49b36a386d6200cb163d482dd70a816019ba2b45f0ff25c3ca4eabf28R209].

There are a few tests failing (same were failing before and after the rebase and they are
not known failures)

The only failing unit test is testDropSSTables which I [changed|https://github.com/apache/cassandra/commit/dba4a86306bc13f1b421c500570deb3a3f06414f]
a bit to show what is the current sequence of messages to have it in mind while debugging.
(That's why it is green in CircleCI)

These are the other failures:

_repairUnreplicatedKStest - org.apache.cassandra.distributed.test.RepairOperationalTest -_ not
sure about this timeout whether it is related; have to check

*EDIT:* _repairUnreplicatedKStest - org.apache.cassandra.distributed.test.RepairOperationalTest
-_ I ran it locally a few times and it passes successfully so I think it was circle ci timeout.
Also, it doesn't seem related

jvm upgrade test [CompactStorage2to3UpgradeTest|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152/jobs/2942]

Also 1 dtest [TestGossipingPropertyFileSnitch|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152/jobs/2940]

I will try to do a more detailed review and try to work out the failures but I guess also
2 committers for review will be needed. Also,  I haven't dealt with our Gossip implementation
up to now.  

 


was (Author: e.dimitrova):
Patch rebased [here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:15897-3.0].
 CI run can be found [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152].

There was a collision between this patch  and CASSANDRA-16228 in [Tracker.java |#diff-9baecde49b36a386d6200cb163d482dd70a816019ba2b45f0ff25c3ca4eabf28L184]

To solve It I added a new flag [updatingSize|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:15897-3.0#diff-9baecde49b36a386d6200cb163d482dd70a816019ba2b45f0ff25c3ca4eabf28R209].

There are a few tests failing (same were failing before and after the rebase and they are
not known failures)

The only failing unit test is testDropSSTables which I [changed|https://github.com/apache/cassandra/commit/dba4a86306bc13f1b421c500570deb3a3f06414f]
a bit to show what is the current sequence of messages to have it in mind while debugging.
(That's why it is green in CircleCI)

These are the other failures:

_repairUnreplicatedKStest - org.apache.cassandra.distributed.test.RepairOperationalTest -_ not
sure about this timeout whether it is related; have to check

*EDIT:* _repairUnreplicatedKStest - org.apache.cassandra.distributed.test.RepairOperationalTest
-_ I ran it locally a few times and it passes successfully so I think it was circle ci timeout.
Also, it doesn't seem related

jvm upgrade test [CompactStorage2to3UpgradeTest|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152/jobs/2942]

Also 1 dtest [TestGossipingPropertyFileSnitch|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/529/workflows/7101b314-681a-40b9-a266-6286c4f27152/jobs/2940]

I will try to do a more detailed review and try to work out the failures but I guess also
2 committers for review will be needed. Also,  I haven't dealt with our Gossip implementation
up to now.  

 

> Dropping compact storage with 2.1-sstables on disk make them unreadable
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-15897
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15897
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Marcus Eriksson
>            Assignee: Sylvain Lebresne
>            Priority: Normal
>             Fix For: 3.0.x, 4.0-beta
>
>
> Test reproducing: https://github.com/krummas/cassandra/commits/marcuse/dropcompactstorage



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message