cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb Rackliffe (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-15909) Make Table/Keyspace Metric Names Consistent With Each Other
Date Tue, 01 Sep 2020 20:26:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188004#comment-17188004
] 

Caleb Rackliffe edited comment on CASSANDRA-15909 at 9/1/20, 8:25 PM:
----------------------------------------------------------------------

Created CASSANDRA-16090 to track eventual removal of the (new and existing) clutter in {{TableMetrics}},
and CASSANDRA-16094 to address the preexisting flaky test in {{TestIncRepair}}.


was (Author: maedhroz):
Created CASSANDRA-16090 to track eventual removal of the (new and existing) clutter in {{TableMetrics}}.

> Make Table/Keyspace Metric Names Consistent With Each Other
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-15909
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15909
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Metrics
>            Reporter: Stephen Mallette
>            Assignee: Caleb Rackliffe
>            Priority: Normal
>             Fix For: 4.0-beta
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> As part of CASSANDRA-15821 it became apparent that certain metric names found in keyspace
and tables had different names but were in fact the same metric - they are as follows:
> * Table.SyncTime == Keyspace.RepairSyncTime
> * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
> * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
> * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
> * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
> * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
> * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize
> Also, client metrics are the only metrics to start with a lower case letter. Change those
to upper case to match all the other metrics.
> Unifying this naming would help make metrics more consistent as part of CASSANDRA-15582



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message