cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Capwell (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16082) Add a new jmxtool which can dump what JMX objects exist and diff
Date Sat, 29 Aug 2020 01:19:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186867#comment-17186867
] 

David Capwell commented on CASSANDRA-16082:
-------------------------------------------

[~Bereng] was hoping you could take a look at the changes to ToolRunner in the PR?  ToolRunner
tried to read stdout and stderr in the same thread which caused a dead lock.  stdout and stderr
are normally bounded queues so when full the publisher is blocked waiting on the consumer,
the tests were reading stderr (which never closed) before stdout which caused stdout to fill
up and block the forked process.  To work around this, stdout and stderr are handled by their
own thread.  Also, the buffer wasn't shared in a safe way so changed how tests access the
stdout and stderr buffers

> Add a new jmxtool which can dump what JMX objects exist and diff
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-16082
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16082
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/python
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In order to help validate metric upgrade we first need to know what is new, what was
removed, and what was changed.  To help with this, we should add a new jmxtool which can dump
the objects from JMX and diff them.
> Once we have this, we can also add a gold list of expected metrics and add tests to validate
these metrics don’t change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message