cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb Rackliffe (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-14888) Several mbeans are not unregistered when dropping a keyspace and table
Date Tue, 09 Jun 2020 00:23:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128733#comment-17128733
] 

Caleb Rackliffe edited comment on CASSANDRA-14888 at 6/9/20, 12:22 AM:
-----------------------------------------------------------------------

[~stillalex] The only thing that immediately jumps out to me about the newer patch is that
we might want to stay consistent with the new [helper methods|https://github.com/apache/cassandra/pull/493/files#diff-40a2ae61c758454cc6166903250edbdfR953]
for metric creation added in CASSANDRA-8272. (i.e. It might also make sense to have a version
of {{createTableTimer()}} that doesn't take a keyspace metric, just an alias...)


was (Author: maedhroz):
[~stillalex] The only thing that immediately jumps out to me about the newer patch is that
we might want to stay consistent with the new [helper methods|https://github.com/apache/cassandra/pull/493/files#diff-40a2ae61c758454cc6166903250edbdfR953]
for metric creation added in CASSANDRA-8272.

> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14888
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Ariel Weisberg
>            Assignee: Alex Deparvu
>            Priority: Urgent
>              Labels: patch-available
>             Fix For: 4.0-beta
>
>         Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests, ShortReadProtectionRequests, AntiCompactionTime,
BytesValidated, PartitionsValidated, RepairPrepareTime, RepairSyncTime, RepairedDataInconsistencies,
ViewLockAcquireTime, ViewReadTime, WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the entire thing
is kind of obscure. Fix it and also add a dtest that detects if any mbeans are left behind
after dropping a table and keyspace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message