cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Semb Wever (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15684) CASSANDRA-15650 was merged after dtest refactor and modified classes no longer in the project
Date Mon, 06 Apr 2020 16:29:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076452#comment-17076452
] 

Michael Semb Wever commented on CASSANDRA-15684:
------------------------------------------------

bq.  Michael Semb Wever if I understand the nature of the failure correctly, the main problem
was merge.

That's my understanding too.

Since both you [~ifesdjeen] and [~blerer] have +1 on the main patch I've gone ahead and committed
it.

Committed as [a104b06d4aea2f2cd3d48bdbe38410284f236428|https://github.com/apache/cassandra/commit/a104b06d4aea2f2cd3d48bdbe38410284f236428]

> CASSANDRA-15650 was merged after dtest refactor and modified classes no longer in the
project
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15684
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15684
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> CASSANDRA-15650 was based off commits before CASSANDRA-15539 which removed some of the
files modified in CASSANDRA-15650.  The tests were passing pre-merge but off earlier commits.
 On commit they started failing since the dtest API no longer match so produces the following
exception
> {code}
> [junit-timeout] org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
> [junit-timeout] java.lang.NoSuchMethodError: org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
> [junit-timeout]         at org.apache.cassandra.distributed.test.RepairCoordinatorFast.lambda$unknownHost$5(RepairCoordinatorFast.java:216)
> [junit-timeout]         at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$0(AssertUtil.java:39)
> [junit-timeout]         at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$1(AssertUtil.java:67)
> [junit-timeout]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [junit-timeout]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [junit-timeout]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [junit-timeout]         at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> [junit-timeout]         at java.lang.Thread.run(Thread.java:748)
> {code}
> Root cause was 4 files exited which should have been deleted in CASSANDRA-15539.  Since
they were not when CASSANDRA-15650 modified one it didn't cause a merge conflict, but when
the test runs it conflicts and fails.
> [Circle CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15684]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message