From commits-return-215663-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Thu Nov 1 12:12:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17E4018077A for ; Thu, 1 Nov 2018 12:12:04 +0100 (CET) Received: (qmail 29361 invoked by uid 500); 1 Nov 2018 11:12:04 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 29192 invoked by uid 99); 1 Nov 2018 11:12:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2018 11:12:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5E0FB184F7C for ; Thu, 1 Nov 2018 11:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id F3keGlBusMyw for ; Thu, 1 Nov 2018 11:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 76AF85F4DB for ; Thu, 1 Nov 2018 11:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BE788E002F for ; Thu, 1 Nov 2018 11:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0EB482776C for ; Thu, 1 Nov 2018 11:12:01 +0000 (UTC) Date: Thu, 1 Nov 2018 11:12:01 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-14862) TestTopology.test_size_estimates_multidc fails on trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-14862: --------------------------------- Status: Ready to Commit (was: Patch Available) > TestTopology.test_size_estimates_multidc fails on trunk > ------------------------------------------------------- > > Key: CASSANDRA-14862 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14862 > Project: Cassandra > Issue Type: Bug > Components: Testing > Reporter: Joseph Lynch > Assignee: Joseph Lynch > Priority: Minor > Fix For: 4.0 > > > The sorting of natural replicas in {{SimpleStrategy.calculateNaturalReplicas}} committed as part of [e645b917|https://github.com/apache/cassandra/commit/e645b9172c5d50fc2af407de724e46121edfe109#diff-0e1563a70b49cd81e9e11b4ddad15cf2L68] for CASSANDRA-14726 has broken the {{TestTopology.test_size_estimates_multidc}} dtest ([example run|https://circleci.com/gh/jolynch/cassandra/245#tests/containers/48]) as the "primary" ranges have now changed. I'm actually surprised only a single dtest fails as I believe we've broken multi-dc {{SimpleStrategy}} reasonably badly. > In particular the {{SimpleStrategy.calculateNaturalReplicas}} method cannot sort the endpoints by datacenter first. It has to leave them in the order that it found them else change which replicas are considered "primary" replicas (which mostly impacts repair and size estimates and the such). > I have written a regression unit test for the SimpleStrategy and am running it through circleci now. Will post the patch shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org