From commits-return-215643-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Thu Nov 1 04:55:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4A1618065D for ; Thu, 1 Nov 2018 04:55:05 +0100 (CET) Received: (qmail 92058 invoked by uid 500); 1 Nov 2018 03:55:04 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 92047 invoked by uid 99); 1 Nov 2018 03:55:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2018 03:55:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9350D1A4B9A for ; Thu, 1 Nov 2018 03:55:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wjXdYQaZeng7 for ; Thu, 1 Nov 2018 03:55:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5C3D55F3EA for ; Thu, 1 Nov 2018 03:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1931E13DA for ; Thu, 1 Nov 2018 03:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2481827766 for ; Thu, 1 Nov 2018 03:55:00 +0000 (UTC) Date: Thu, 1 Nov 2018 03:55:00 +0000 (UTC) From: "Joseph Lynch (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-14862) TestTopology.test_size_estimates_multidc fails on trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14862?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Lynch updated CASSANDRA-14862: ------------------------------------- Description:=20 The sorting of natural replicas in {{SimpleStrategy.calculateNaturalReplica= s}} committed as part of [e645b917|https://github.com/apache/cassandra/comm= it/e645b9172c5d50fc2af407de724e46121edfe109#diff-0e1563a70b49cd81e9e11b4dda= d15cf2L68] for CASSANDRA-14726 has broken the {{TestTopology.test_size_esti= mates_multidc}} dtest ([example run|https://circleci.com/gh/jolynch/cassand= ra/245#tests/containers/48]) as the "primary" ranges have now changed. I'm = actually surprised only a single dtest fails as I believe we've broken mult= i-dc {{SimpleStrategy}} reasonably badly. In particular the {{SimpleStrategy.calculateNaturalReplicas}} method cannot= sort the endpoints by datacenter first. It has to leave them in the order = that it found them else change which replicas are considered "primary" repl= icas (which mostly impacts repair and size estimates and the such). I have written a regression unit test for the SimpleStrategy and am running= it through circleci now. Will post the patch shortly. was: The sorting of natural replicas in {{SimpleStrategy.calculateNaturalReplica= s}} committed as part of [e645b917|https://github.com/apache/cassandra/comm= it/e645b9172c5d50fc2af407de724e46121edfe109#diff-0e1563a70b49cd81e9e11b4dda= d15cf2L68] for CASSANDRA-14726 has broken the {{TestTopology.test_size_esti= mates_multidc}} dtest ([example run|https://circleci.com/gh/jolynch/cassand= ra/245#tests/containers/48]) as the "primary" ranges have now changed. I'm = actually surprised only a single dtest fails as I believe we've broken mult= i-dc {{SimpleStrategy}} reasonably badly. In particular {{SimpleStrategy calculateNaturalReplicas=C2=A0}}method canno= t sort the endpoints by datacenter first. It has to leave them in the order= that it found them else change which replicas are considered "primary" rep= licas (which mostly impacts repair and size estimates and the such). I have written a regression unit test for the SimpleStrategy and am running= it through circleci now. Will post the patch shortly. > TestTopology.test_size_estimates_multidc fails on trunk > ------------------------------------------------------- > > Key: CASSANDRA-14862 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1486= 2 > Project: Cassandra > Issue Type: Bug > Components: Testing > Reporter: Joseph Lynch > Priority: Minor > Fix For: 4.0 > > > The sorting of natural replicas in {{SimpleStrategy.calculateNaturalRepli= cas}} committed as part of [e645b917|https://github.com/apache/cassandra/co= mmit/e645b9172c5d50fc2af407de724e46121edfe109#diff-0e1563a70b49cd81e9e11b4d= dad15cf2L68] for CASSANDRA-14726 has broken the {{TestTopology.test_size_es= timates_multidc}} dtest ([example run|https://circleci.com/gh/jolynch/cassa= ndra/245#tests/containers/48]) as the "primary" ranges have now changed. I'= m actually surprised only a single dtest fails as I believe we've broken mu= lti-dc {{SimpleStrategy}} reasonably badly. > In particular the {{SimpleStrategy.calculateNaturalReplicas}} method cann= ot sort the endpoints by datacenter first. It has to leave them in the orde= r that it found them else change which replicas are considered "primary" re= plicas (which mostly impacts repair and size estimates and the such). > I have written a regression unit test for the SimpleStrategy and am runni= ng it through circleci now. Will post the patch shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org