From commits-return-216784-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Mon Nov 19 03:39:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3267118066C for ; Mon, 19 Nov 2018 03:39:12 +0100 (CET) Received: (qmail 1735 invoked by uid 500); 19 Nov 2018 02:39:11 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 1723 invoked by uid 99); 19 Nov 2018 02:39:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2018 02:39:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6585A180C68 for ; Mon, 19 Nov 2018 02:39:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wn1bpmSPilPj for ; Mon, 19 Nov 2018 02:39:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 96CF86116A for ; Mon, 19 Nov 2018 02:32:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9E635E0104 for ; Mon, 19 Nov 2018 02:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 144C823FA3 for ; Mon, 19 Nov 2018 02:32:01 +0000 (UTC) Date: Mon, 19 Nov 2018 02:32:01 +0000 (UTC) From: "C. Scott Andreas (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-11688) Replace_address should sanity check prior node state before migrating tokens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11688?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:all-tabpanel ] C. Scott Andreas updated CASSANDRA-11688: ----------------------------------------- Component/s: Streaming and Messaging > Replace_address should sanity check prior node state before migrating tok= ens > -------------------------------------------------------------------------= --- > > Key: CASSANDRA-11688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1168= 8 > Project: Cassandra > Issue Type: Improvement > Components: Streaming and Messaging > Reporter: Jonathan Shook > Priority: Major > > During a node replacement, a replace_address was used which was associate= d with a different node than the intended one. The result was that both nod= es remained active after the node came up. This caused several other issues= which were difficult to diagnose, including invalid gossip state, etc. > Replace_address should be more robust in this scenario. It would be much = more user friendly if the replace_address logic would first do some basic s= anity checks, possibly to include: > - Pinging the other node to see if it is indeed =E2=80=9Cdown=E2=80=9D, i= f the address is different than all local interface addresses > - Checking gossip state of the node to verify that it is not known to pee= rs. > It may even be safest to require that both address reachability and gossi= p state are required to show the replace_address as down by default before = allowing any token migration or other replace_address actions to occur. > In the case that the replace_address is not ready to be replaced, the log= should indicate that you are trying to replace an active node, and cassand= ra should refuse to start. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org