cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-14862) TestTopology.test_size_estimates_multidc fails on trunk
Date Thu, 01 Nov 2018 11:12:01 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-14862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedict updated CASSANDRA-14862:
---------------------------------
    Status: Ready to Commit  (was: Patch Available)

> TestTopology.test_size_estimates_multidc fails on trunk
> -------------------------------------------------------
>
>                 Key: CASSANDRA-14862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14862
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Joseph Lynch
>            Assignee: Joseph Lynch
>            Priority: Minor
>             Fix For: 4.0
>
>
> The sorting of natural replicas in {{SimpleStrategy.calculateNaturalReplicas}} committed
as part of [e645b917|https://github.com/apache/cassandra/commit/e645b9172c5d50fc2af407de724e46121edfe109#diff-0e1563a70b49cd81e9e11b4ddad15cf2L68]
for CASSANDRA-14726 has broken the {{TestTopology.test_size_estimates_multidc}} dtest ([example
run|https://circleci.com/gh/jolynch/cassandra/245#tests/containers/48]) as the "primary" ranges
have now changed. I'm actually surprised only a single dtest fails as I believe we've broken
multi-dc {{SimpleStrategy}} reasonably badly.
> In particular the {{SimpleStrategy.calculateNaturalReplicas}} method cannot sort the
endpoints by datacenter first. It has to leave them in the order that it found them else change
which replicas are considered "primary" replicas (which mostly impacts repair and size estimates
and the such).
> I have written a regression unit test for the SimpleStrategy and am running it through
circleci now. Will post the patch shortly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message