cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Zegelin (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-14819) Certain table metrics not released when table is dropped.
Date Thu, 11 Oct 2018 23:12:00 GMT
Adam Zegelin created CASSANDRA-14819:
----------------------------------------

             Summary: Certain table metrics not released when table is dropped.
                 Key: CASSANDRA-14819
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14819
             Project: Cassandra
          Issue Type: Bug
          Components: Metrics
            Reporter: Adam Zegelin
         Attachments: release-metrics.patch

The following metrics are not released when a table is dropped:
 * {{CasCommitLatency}}
 * {{CasCommitTotalLatency}}
 * {{CasPrepareLatency}}
 * {{CasPrepareTotalLatency}}
 * {{CasProposeLatency}}
 * {{CasProposeTotalLatency}}
 * {{ReadRepairRequests}}
 * {{ShortReadProtectionRequests}}

 

This can be verified by inspecting the list of exported MBeans after creating a table then
dropping it.

The result is that if a table with the same name is re-created then the above metrics wont
be updated - internally a {{javax.management.InstanceAlreadyExistsException}} is thrown by
the {{MBeanServer}} and this exception is silently ignored by {{org.apache.cassandra.metrics.CassandraMetricsRegistry#registerMBean}}

The above metrics were added in 2014/2015, so this issue probably affects all versions released
since then.

 

Attached a patch that releases/removes the metrics when the table is dropped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message