cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Lohfink (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14787) nodetool status "Load" columns has wrong width
Date Thu, 18 Oct 2018 14:24:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655302#comment-16655302
] 

Chris Lohfink commented on CASSANDRA-14787:
-------------------------------------------

The offset should be from the max width instead of hard coded since it can vary so much. The
other nodetool outputs have been moving to use {{TableBuilder}} so that it always aligns
properly. Perhaps this table can be changed to use it as well.

> nodetool status "Load" columns has wrong width
> ----------------------------------------------
>
>                 Key: CASSANDRA-14787
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14787
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Lapo Luchini
>            Assignee: Kirk True
>            Priority: Trivial
>              Labels: lhf, nodetool, pull-request-available
>             Fix For: 4.x
>
>         Attachments: CASSANDRA-14787.txt
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Using Cassandra 3.11.2 on FreeBSD, I get:
> {code:java}
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  Address            Load       Tokens       Owns (effective)  Host ID ...
> UN  server1.andxor.it  11.11 MiB  256          39.6%             ...
> UN  server2.andxor.it  32.04 MiB  256          41.8%             ...
> UN  server3.andxor.it  519.33 KiB  256          40.0%             ...
> UN  server4.andxor.it  10.95 MiB  256          40.3%             ...
> UN  server5.andxor.it  11.03 MiB  256          38.4%             ...
> {code}
> AFAICT this is caused by {{"%-9s"}} in [Status.java:292|https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/tools/nodetool/Status.java#L292] which
should be probably a 10 instead of 9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message