cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-14662) Refactor AuthCache
Date Sat, 01 Sep 2018 20:49:00 GMT


Sam Tunnicliffe updated CASSANDRA-14662:
       Resolution: Fixed
    Fix Version/s:     (was: 4.x)
           Status: Resolved  (was: Patch Available)

Thanks [~KurtG], committed in {{960174da67eb6008c73340e61700ea34ec550a12}}

> Refactor AuthCache
> ------------------
>                 Key: CASSANDRA-14662
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Auth
>            Reporter: Kurt Greaves
>            Assignee: Kurt Greaves
>            Priority: Major
>              Labels: security
>             Fix For: 4.0
> When building an LDAP IAuthenticator plugin I ran into a few issues when trying to reuse
the AuthCache similar to how PasswordAuthenticator implements it. Most of the problems stemmed
from the underlying cache being inaccessible and not being able to override {{initCache}}
> Anyway, I've had a stab at refactoring AuthCache with the following improvements:
> # Make it possible to extend and override all necessary methods (initCache, init, validate)
> # Makes it possible to specify a {{CacheLoader}} rather than just a {{Function}}, allowing
you to have a get/load that throws exceptions.
> # Use AuthCache on its own rather than extending it for each use case ({{invalidate(K)}}
moved to be part of MBean)
> # Provided a builder that uses sane defaults so we don't have unnecessary repeated code
> The refactor made all the extensions of AuthCache unnecessary, so I've simplified those
cases to use AuthCache and removed any classes extending AuthCache. I also removed some noop
compatibility classes that were marked to be removed in 4.0.
> Also added some tests in AuthCacheTest.
> |[trunk|]|
> |[utests|]|

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message