cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14649) Index summaries fail when their size gets > 2G and use more space than necessary
Date Thu, 16 Aug 2018 16:20:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582769#comment-16582769
] 

Benedict commented on CASSANDRA-14649:
--------------------------------------

You're right, I was just assuming {{length()}} was inherited from {{DataOutputBuffer}}

I realise {{ensureCapacity}} was a terrible suggestion, but {{ensureHeadroom}} might be clearer
than {{expandToFit}} since it might be that you're trying to fit N total, not N extra.

But no strong feeling, and +1 either way.

> Index summaries fail when their size gets > 2G and use more space than necessary
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14649
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14649
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Major
>
> After building a summary, {{IndexSummaryBuilder}} tries to trim the memory writers by
calling {{SafeMemoryWriter.setCapacity(capacity())}}. Instead of trimming, this ends up allocating
at least as much extra space and failing the {{Buffer.position()}} call when the size is
greater than {{Integer.MAX_VALUE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message