From commits-return-212184-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Tue Jul 24 14:10:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BF24180626 for ; Tue, 24 Jul 2018 14:10:11 +0200 (CEST) Received: (qmail 91815 invoked by uid 500); 24 Jul 2018 12:10:06 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 91804 invoked by uid 99); 24 Jul 2018 12:10:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2018 12:10:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CD5D81A024F for ; Tue, 24 Jul 2018 12:10:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7jpe2Cv9WM4K for ; Tue, 24 Jul 2018 12:10:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 849005F381 for ; Tue, 24 Jul 2018 12:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BBA4AE0D42 for ; Tue, 24 Jul 2018 12:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3B2D12774A for ; Tue, 24 Jul 2018 12:10:00 +0000 (UTC) Date: Tue, 24 Jul 2018 12:10:00 +0000 (UTC) From: "Jason Brown (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-14545) dtests: fix pytest.raises argument names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554170#comment-16554170 ] Jason Brown commented on CASSANDRA-14545: ----------------------------------------- [~mkjellman] isn't around these days, so I've taken a look. Double checked {{master}} for other {{msg}}/{{matches}} and this patch got them all. I also checked the pytest source to make sure {{match}}/{{message}} are the correct param names (they are). +1 > dtests: fix pytest.raises argument names > ---------------------------------------- > > Key: CASSANDRA-14545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14545 > Project: Cassandra > Issue Type: Bug > Components: Testing > Reporter: Stefan Podkowinski > Assignee: Stefan Podkowinski > Priority: Major > Attachments: CASSANDRA-14545.patch > > > I've been through a couple of [dtest results|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/580/#showFailuresLink] lately and notices some interpreter errors regarding how we call pytest.raises. The [reference|https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions] is pretty clear on what would be the correct arguments, but still want to make sure we're not working on different pytest versions. > [~mkjellman] can you quickly check the following inconsistencies and look at my patch (msg->message, matches->match)? > {noformat} > git show 49b2dda4 |egrep 'raises.*, m' {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org