From commits-return-211754-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Thu Jul 5 19:12:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3BFE8180657 for ; Thu, 5 Jul 2018 19:12:05 +0200 (CEST) Received: (qmail 63348 invoked by uid 500); 5 Jul 2018 17:12:04 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 63337 invoked by uid 99); 5 Jul 2018 17:12:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jul 2018 17:12:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7E49EC041A for ; Thu, 5 Jul 2018 17:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vrxVT0IOB3Z9 for ; Thu, 5 Jul 2018 17:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 292735F19D for ; Thu, 5 Jul 2018 17:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0901CE1204 for ; Thu, 5 Jul 2018 17:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6417927510 for ; Thu, 5 Jul 2018 17:12:00 +0000 (UTC) Date: Thu, 5 Jul 2018 17:12:00 +0000 (UTC) From: "Jay Zhuang (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-14252) Use zero as default score in DynamicEndpointSnitch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14252?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16533909#comment-16533909 ]=20 Jay Zhuang commented on CASSANDRA-14252: ---------------------------------------- The change is reverted from 3.0 and 3.11 branches. More details: CASSANDRA-= 14555 > Use zero as default score in DynamicEndpointSnitch > -------------------------------------------------- > > Key: CASSANDRA-14252 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1425= 2 > Project: Cassandra > Issue Type: Bug > Components: Coordination > Reporter: Dikang Gu > Assignee: Dikang Gu > Priority: Major > Fix For: 4.0 > > Attachments: IMG_3180.jpg > > > The problem=C2=A0I want to solve is that I found in our deployment, one s= low but alive data node can slow down the whole cluster, even caused timeou= t of our requests.=C2=A0 > We are using DynamicEndpointSnitch, with badness_threshold 0.1. I=C2=A0ex= pect the=C2=A0DynamicEndpointSnitch switch to=C2=A0sortByProximityWithScore= , if local data node latency is too high. > I=C2=A0added some debug log, and figured out that in a lot of cases, the = score from remote data node=C2=A0was not populated, so the fallback to=C2= =A0sortByProximityWithScore never happened. That's why a single slow data n= ode, can cause huge problems to the whole cluster. > In this jira, I'd like to use zero as default score, so that we will get = a chance to try remote data node, if local one is slow.=C2=A0 > I tested it in our test cluster, it improved the client latency in=C2=A0s= ingle slow data node=C2=A0case significantly.=C2=A0=C2=A0 > I flag this as a Bug, because it caused problems to our=C2=A0use cases mu= ltiple times. > =C2=A0=3D=3D=3D=3D logs =3D=3D=3D > _2018-02-21_23:08:57.54145 WARN 23:08:57 [RPC-Thread:978]: sortByProximit= yWithBadness: after sorting by proximity, addresses order change to [ip1,= =C2=A0ip2], with scores [1.0]_ > _2018-02-21_23:08:57.54319 WARN 23:08:57 [RPC-Thread:967]: sortByProximi= tyWithBadness: after sorting by proximity, addresses order change to [ip1,= =C2=A0ip2], with scores [0.0]_ > _2018-02-21_23:08:57.55111 WARN 23:08:57 [RPC-Thread:453]: sortByProximi= tyWithBadness: after sorting by proximity, addresses order change to [ip1,= =C2=A0ip2], with scores [1.0]_ > _2018-02-21_23:08:57.55687 WARN 23:08:57 [RPC-Thread:753]: sortByProximi= tyWithBadness: after sorting by proximity, addresses order change to [ip1,= =C2=A0ip2], with scores [1.0]_ > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org