cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordan West (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14442) Let nodetool import take a list of directories
Date Fri, 01 Jun 2018 05:00:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497552#comment-16497552
] 

Jordan West commented on CASSANDRA-14442:
-----------------------------------------

[~krummas] LGTM overall. One thing I wanted to check: is it ok that callers of importNewSSTables
can now run concurrently with callers of CFS#runWithCompactionsDisabled (callers like truncate
and clearUnsafe)? 

Some minor things:
* Remove the whitespace only change in Tracker
* Rename first argument of CFS#importNewSSTables to srcPaths
* Consider moving {{SSTableImporter#moveAndOpenSSTable}} to be a static method on SSTable,
maybe {{renameAndOpen}} (it may be useful for future uses/tests and isn’t specific to {{SSTableImporter}})
* Thanks for adding the new dtests. Should they be marked since 4.0?

> Let nodetool import take a list of directories
> ----------------------------------------------
>
>                 Key: CASSANDRA-14442
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14442
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
>
>
> It should be possible to load sstables from several input directories when running nodetool
import. Directories that failed to import should be output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message