cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Zhuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13929) BTree$Builder / io.netty.util.Recycler$Stack leaking memory
Date Fri, 08 Jun 2018 19:12:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506462#comment-16506462
] 

Jay Zhuang commented on CASSANDRA-13929:
----------------------------------------

Thanks [~jasobrown] again for the review. Committed as [{{ed5f834}}|https://github.com/apache/cassandra/commit/ed5f8347ef0c7175cd96e59bc8bfaf3ed1f4697a].

> BTree$Builder / io.netty.util.Recycler$Stack leaking memory
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-13929
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13929
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Thomas Steinmaurer
>            Assignee: Jay Zhuang
>            Priority: Major
>             Fix For: 3.11.3
>
>         Attachments: cassandra_3.11.0_min_memory_utilization.jpg, cassandra_3.11.1_NORECYCLE_memory_utilization.jpg,
cassandra_3.11.1_mat_dominator_classes.png, cassandra_3.11.1_mat_dominator_classes_FIXED.png,
cassandra_3.11.1_snapshot_heaputilization.png, cassandra_3.11.1_vs_3.11.2recyclernullingpatch.png,
cassandra_heapcpu_memleak_patching_test_30d.png, dtest_example_80_request.png, dtest_example_80_request_fix.png,
dtest_example_heap.png, memleak_heapdump_recyclerstack.png
>
>
> Different to CASSANDRA-13754, there seems to be another memory leak in 3.11.0+ in BTree$Builder
/ io.netty.util.Recycler$Stack.
> * heap utilization increase after upgrading to 3.11.0 => cassandra_3.11.0_min_memory_utilization.jpg
> * No difference after upgrading to 3.11.1 (snapshot build) => cassandra_3.11.1_snapshot_heaputilization.png;
thus most likely after fixing CASSANDRA-13754, more visible now
> * MAT shows io.netty.util.Recycler$Stack as top contributing class => cassandra_3.11.1_mat_dominator_classes.png
> * With -Xmx8G (CMS) and our load pattern, we have to do a rolling restart after ~ 72
hours
> Verified the following fix, namely explicitly unreferencing the _recycleHandle_ member
(making it non-final). In _org.apache.cassandra.utils.btree.BTree.Builder.recycle()_
> {code}
>         public void recycle()
>         {
>             if (recycleHandle != null)
>             {
>                 this.cleanup();
>                 builderRecycler.recycle(this, recycleHandle);
>                 recycleHandle = null; // ADDED
>             }
>         }
> {code}
> Patched a single node in our loadtest cluster with this change and after ~ 10 hours uptime,
no sign of the previously offending class in MAT anymore => cassandra_3.11.1_mat_dominator_classes_FIXED.png
> Can' say if this has any other side effects etc., but I doubt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message