From commits-return-209454-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Wed Apr 25 07:34:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 71C29180679 for ; Wed, 25 Apr 2018 07:34:04 +0200 (CEST) Received: (qmail 47368 invoked by uid 500); 25 Apr 2018 05:34:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 47357 invoked by uid 99); 25 Apr 2018 05:34:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2018 05:34:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7B9A8C02CF for ; Wed, 25 Apr 2018 05:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tJcPkR5xEXSG for ; Wed, 25 Apr 2018 05:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 102265F3CE for ; Wed, 25 Apr 2018 05:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6AE04E00C6 for ; Wed, 25 Apr 2018 05:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2335C2120A for ; Wed, 25 Apr 2018 05:34:00 +0000 (UTC) Date: Wed, 25 Apr 2018 05:34:00 +0000 (UTC) From: "Chris Lohfink (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-14410) tablehistograms with non-existent table gives an exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14410?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16451676#comment-16451676 ]=20 Chris Lohfink commented on CASSANDRA-14410: ------------------------------------------- nitpick: {{Collections.singletonList(table)}} instead of {{new ArrayList(Arrays.asList(input[1]))}} (I realize this is from previous not added= by your patch) +1 from me with that > tablehistograms with non-existent table gives an exception > ---------------------------------------------------------- > > Key: CASSANDRA-14410 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1441= 0 > Project: Cassandra > Issue Type: Bug > Components: Tools > Reporter: Hannu Kr=C3=B6ger > Assignee: Hannu Kr=C3=B6ger > Priority: Major > Labels: lhf > Fix For: 3.11.x > > > nodetool tablehistograms with non-existent table gives a crazy exception.= It should give a nice error message like "Table acdc.abba doesn't exist" o= r something like that. > =C2=A0 > Example: > {code:java} > $ nodetool tablehistograms acdc.abba > error: org.apache.cassandra.metrics:type=3DTable,keyspace=3Dacdc,scope=3D= abba,name=3DEstimatedPartitionSizeHistogram > -- StackTrace -- > javax.management.InstanceNotFoundException: org.apache.cassandra.metrics:= type=3DTable,keyspace=3Dacdc,scope=3Dabba,name=3DEstimatedPartitionSizeHist= ogram > =C2=A0=C2=A0 =C2=A0at com.sun.jmx.interceptor.DefaultMBeanServerIntercept= or.getMBean(DefaultMBeanServerInterceptor.java:1095) > =C2=A0=C2=A0 =C2=A0at com.sun.jmx.interceptor.DefaultMBeanServerIntercept= or.getAttribute(DefaultMBeanServerInterceptor.java:643) > =C2=A0=C2=A0 =C2=A0at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute= (JmxMBeanServer.java:678) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl.doOpe= ration(RMIConnectionImpl.java:1445) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl.acces= s$300(RMIConnectionImpl.java:76) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl$Privi= legedOperation.run(RMIConnectionImpl.java:1309) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl.doPri= vilegedOperation(RMIConnectionImpl.java:1401) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl.getAt= tribute(RMIConnectionImpl.java:639) > =C2=A0=C2=A0 =C2=A0at sun.reflect.GeneratedMethodAccessor297.invoke(Unkno= wn Source) > =C2=A0=C2=A0 =C2=A0at sun.reflect.DelegatingMethodAccessorImpl.invoke(Del= egatingMethodAccessorImpl.java:43) > =C2=A0=C2=A0 =C2=A0at java.lang.reflect.Method.invoke(Method.java:498) > =C2=A0=C2=A0 =C2=A0at sun.rmi.server.UnicastServerRef.dispatch(UnicastSer= verRef.java:324) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.Transport$1.run(Transport.java:20= 0) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.Transport$1.run(Transport.java:19= 7) > =C2=A0=C2=A0 =C2=A0at java.security.AccessController.doPrivileged(Native = Method) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.Transport.serviceCall(Transport.j= ava:196) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.tcp.TCPTransport.handleMessages(T= CPTransport.java:568) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.tcp.TCPTransport$ConnectionHandle= r.run0(TCPTransport.java:826) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.tcp.TCPTransport$ConnectionHandle= r.lambda$run$0(TCPTransport.java:683) > =C2=A0=C2=A0 =C2=A0at java.security.AccessController.doPrivileged(Native = Method) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.tcp.TCPTransport$ConnectionHandle= r.run(TCPTransport.java:682) > =C2=A0=C2=A0 =C2=A0at java.util.concurrent.ThreadPoolExecutor.runWorker(T= hreadPoolExecutor.java:1142) > =C2=A0=C2=A0 =C2=A0at java.util.concurrent.ThreadPoolExecutor$Worker.run(= ThreadPoolExecutor.java:617) > =C2=A0=C2=A0 =C2=A0at java.lang.Thread.run(Thread.java:745) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.StreamRemoteCall.exceptionReceive= dFromServer(StreamRemoteCall.java:283) > =C2=A0=C2=A0 =C2=A0at sun.rmi.transport.StreamRemoteCall.executeCall(Stre= amRemoteCall.java:260) > =C2=A0=C2=A0 =C2=A0at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:16= 1) > =C2=A0=C2=A0 =C2=A0at com.sun.jmx.remote.internal.PRef.invoke(Unknown Sou= rce) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnectionImpl_Stub.= getAttribute(Unknown Source) > =C2=A0=C2=A0 =C2=A0at javax.management.remote.rmi.RMIConnector$RemoteMBea= nServerConnection.getAttribute(RMIConnector.java:903) > =C2=A0=C2=A0 =C2=A0at javax.management.MBeanServerInvocationHandler.invok= e(MBeanServerInvocationHandler.java:273) > =C2=A0=C2=A0 =C2=A0at com.sun.proxy.$Proxy20.getValue(Unknown Source) > =C2=A0=C2=A0 =C2=A0at org.apache.cassandra.tools.NodeProbe.getColumnFamil= yMetric(NodeProbe.java:1334) > =C2=A0=C2=A0 =C2=A0at org.apache.cassandra.tools.nodetool.TableHistograms= .execute(TableHistograms.java:62) > =C2=A0=C2=A0 =C2=A0at org.apache.cassandra.tools.NodeTool$NodeToolCmd.run= (NodeTool.java:254) > =C2=A0=C2=A0 =C2=A0at org.apache.cassandra.tools.NodeTool.main(NodeTool.j= ava:168){code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org