From commits-return-209562-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Fri Apr 27 15:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 52DE1180608 for ; Fri, 27 Apr 2018 15:40:04 +0200 (CEST) Received: (qmail 24537 invoked by uid 500); 27 Apr 2018 13:40:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 24525 invoked by uid 99); 27 Apr 2018 13:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2018 13:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B923D1A29FA for ; Fri, 27 Apr 2018 13:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AT_m_mlLW_-Q for ; Fri, 27 Apr 2018 13:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 77B995F5E0 for ; Fri, 27 Apr 2018 13:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DBFDAE010F for ; Fri, 27 Apr 2018 13:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6EE5C24257 for ; Fri, 27 Apr 2018 13:40:00 +0000 (UTC) Date: Fri, 27 Apr 2018 13:40:00 +0000 (UTC) From: "Chris Lohfink (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7622) Implement virtual tables MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456443#comment-16456443 ] Chris Lohfink commented on CASSANDRA-7622: ------------------------------------------ > I do think it would be worth separating the discussion on the system view/virtual table mechanism from the one on the exact schema of metrics tables for the sake of focus agreed, I removed table_stats from system_view and it can be discussed in another ticket. That leaves {{settings}}, {{compaction_stats}}, {{ring_state}}. Thats 2 essentially copies of the nodetool output and a new table that lets you see current state of the configuration (with a few updatable). > I am strongly in favor of not shipping syntax for creating virtual tables Removing CQL syntax change and {{CreateTableStatement}} changes. Will build the tablemetadata from builder instead in the {{SystemViewKeyspace}}. > The patch seems to disable the {{ALLOW FILTERING}} check for virtual tables The patch allows each virtual table to enable or disable the restrictions that normally would require {{ALLOW FILTERING}} to make {code:java} /** * If the table allows unrestricted queries (ie filter on clustering key with no partition). Since These tables are * not backed by the C* data model, this restriction isnt always necessary. */ public boolean allowFiltering() { return true; } {code} I will change default to have same behavior as normal C* tables, but I actually really would like to remove those restrictions on queries for the {{SystemView}} tables since they dont need them and it makes querying interesting things a lot easier. > naming is important agreed but its hard to have 100% foresight, the goal of this ticket shifted dramatically through its lifetime even. I went with {{VirtualTable}} being the base abstract class for a custom backend, but the one implementation provided is a {{SystemView}} to make it easier to make internal system state/metrics tables. > Implement virtual tables > ------------------------ > > Key: CASSANDRA-7622 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7622 > Project: Cassandra > Issue Type: Improvement > Components: CQL > Reporter: Tupshin Harper > Assignee: Chris Lohfink > Priority: Major > Fix For: 4.x > > Attachments: screenshot-1.png > > > There are a variety of reasons to want virtual tables, which would be any table that would be backed by an API, rather than data explicitly managed and stored as sstables. > One possible use case would be to expose JMX data through CQL as a resurrection of CASSANDRA-3527. > Another is a more general framework to implement the ability to expose yaml configuration information. So it would be an alternate approach to CASSANDRA-7370. > A possible implementation would be in terms of CASSANDRA-7443, but I am not presupposing. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org