cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-14416) Remove string formatting lines from hot path
Date Wed, 25 Apr 2018 06:20:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-14416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jeff Jirsa updated CASSANDRA-14416:
-----------------------------------
    Status: Patch Available  (was: Open)

Here is the patch, please review:

|| Patch || Tests ||
| [3.11|https://github.com/jeffjirsa/cassandra/commit/8141bec7061168f91366f8d6d526bd49e2babad2]
| [circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/14416-3.11] |
| [trunk|https://github.com/jeffjirsa/cassandra/commit/8141bec7061168f91366f8d6d526bd49e2babad2]
| [circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/14416] |



> Remove string formatting lines from hot path
> --------------------------------------------
>
>                 Key: CASSANDRA-14416
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14416
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.11.x, 4.x
>
>
> In the BufferPool, we have a {{NoSpamLogger}} that gets called in some conditions (like
when we're at or near the cap in a given pool), which has some string formatting on it. In
situations where that log line is invoked, that string formatting gets called before the rate
limiting, which becomes expensive. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message