cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13698) Reinstate or get rid of unit tests with multiple compaction strategies
Date Thu, 05 Apr 2018 14:48:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427050#comment-16427050
] 

Paulo Motta commented on CASSANDRA-13698:
-----------------------------------------

Sorry for the delay here, the ticket was not marked as patch available so it felt through
the cracks.

The changes look great, thanks! Can you rebase the trunk patch and provide 3.0/3.11 patches?

> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13698
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
>             Project: Cassandra
>          Issue Type: Test
>          Components: Testing
>            Reporter: Paulo Motta
>            Assignee: Lerh Chuan Low
>            Priority: Minor
>              Labels: lhf
>
> At some point there were (anti-)compaction tests with multiple compaction strategy classes,
but now it's only tested with {{STCS}}:
> * [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> * [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and remove the
unused parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message