cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14330) Handle repeat open bound from SRP in read repair
Date Fri, 23 Mar 2018 14:30:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411459#comment-16411459
] 

Sylvain Lebresne commented on CASSANDRA-14330:
----------------------------------------------

+1, fix lgtm. Nice job tracking that down and on the minimal test.

> Handle repeat open bound from SRP in read repair
> ------------------------------------------------
>
>                 Key: CASSANDRA-14330
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14330
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Major
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If there is an open range tombstone in an iterator, a short read protection request for
it will include a repeat open bound. Currently, {{DataResolver}} doesn't expect this, and
will raise an assertion, timing out the request:
> {code}
> java.lang.AssertionError: Error merging RTs on test.test: merged=null, versions=[Marker
EXCL_START_BOUND(0)@0, null], sources={[/127.0.0.1, /127.0.0.2]}, responses:
>     /127.0.0.1 => [test.test] key=0 partition_deletion=deletedAt=-9223372036854775808,
localDeletion=2147483647 columns=[[] | []]
>        Row[info=[ts=1] ]: ck=0 | ,
>    /127.0.0.2 => [test.test] key=0 partition_deletion=deletedAt=-9223372036854775808,
localDeletion=2147483647 columns=[[] | []]
>        Row[info=[ts=-9223372036854775808] del=deletedAt=1, localDeletion=1521572669 ]:
ck=0 |
>        Row[info=[ts=1] ]: ck=1 | 
> {code}
> As this is a completely normal/common scenario, we should allow for this, and relax the
assertion.
> Additionally, the linked branch makes the re-trhowing {{AssertionError}} more detailed
and more correct: the responses are now printed out in the correct order, respecting {{isReversed}},
the command causing the assertion is now logged, as is {{isReversed}} itself, and local deletion
times for RTs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message