From commits-return-206721-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org Wed Feb 21 01:29:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CB07F18076D for ; Wed, 21 Feb 2018 01:29:18 +0100 (CET) Received: (qmail 6999 invoked by uid 500); 21 Feb 2018 00:29:17 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 6971 invoked by uid 99); 21 Feb 2018 00:29:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 00:29:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EA3E318032D for ; Wed, 21 Feb 2018 00:29:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fsYyk-oZ0Y0R for ; Wed, 21 Feb 2018 00:29:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6AA215FAC9 for ; Wed, 21 Feb 2018 00:29:15 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A3456E031B for ; Wed, 21 Feb 2018 00:29:13 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7D92122856 for ; Wed, 21 Feb 2018 00:29:10 +0000 (UTC) Date: Wed, 21 Feb 2018 00:29:10 +0000 (UTC) From: "Sam Tunnicliffe (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-14244) Some tests in read_repair_test are flakey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-14244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-14244: ---------------------------------------- Status: Patch Available (was: Open) DTest PR for this here: https://github.com/apache/cassandra-dtest/pull/20 One additional change I made, aside from setting the table options, was to disable dynamic snitch as this could also cause a coordinator to direct a read command to another replicwhen it could execute it itself. CI is running against that dtest branch and I haven't seen a failure in over 50 runs locally https://circleci.com/workflow-run/69c20512-3407-45e9-887a-5a7b2f7ea95b > Some tests in read_repair_test are flakey > ----------------------------------------- > > Key: CASSANDRA-14244 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14244 > Project: Cassandra > Issue Type: Test > Components: Testing > Reporter: Sam Tunnicliffe > Assignee: Sam Tunnicliffe > Priority: Major > Labels: dtest > > Since being refactored for CASSANDRA-14134, {{test_alter_rf_and_run_read_repair}} and {{test_read_repair_chance}} in {{read_repair_test.TestReadRepair}} are flakey and regularly fail on all branches. The problem is that the inital setup of these two tests doesn't explicitly set the {{read_repair_chance}} or {{dclocal_read_repair_chance}} properties on the test table. As a consequence, read repairs are sometimes probabilistically triggered and query results don't match the expectations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org