cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Hardouin (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-14218) Deprecate Throwables.propagate usage
Date Wed, 07 Feb 2018 11:23:00 GMT
Romain Hardouin created CASSANDRA-14218:
-------------------------------------------

             Summary: Deprecate Throwables.propagate usage
                 Key: CASSANDRA-14218
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14218
             Project: Cassandra
          Issue Type: Improvement
          Components: Libraries
            Reporter: Romain Hardouin


Google deciced to deprecate guava {{Throwables.propagate}} method:
 * [Why we deprecated Throwables.propagate|https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate]
 * [Documentation update|https://github.com/google/guava/wiki/ThrowablesExplained/_compare/92190ee7e37d334fa5fcdb6db8d0f43a2fdf02e1...226a3060445716d479981e606f589c99eee517ca]

We have 35 occurences in the trunk:
{code:java}
$ rg -c 'Throwables.propagate' *
src/java/org/apache/cassandra/streaming/StreamReader.java:1
src/java/org/apache/cassandra/streaming/StreamTransferTask.java:1
src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java:1
src/java/org/apache/cassandra/db/Memtable.java:1
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:4
src/java/org/apache/cassandra/cache/ChunkCache.java:2
src/java/org/apache/cassandra/utils/WrappedRunnable.java:1
src/java/org/apache/cassandra/hints/Hint.java:1
src/java/org/apache/cassandra/tools/LoaderOptions.java:1
src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java:1
src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:3
src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:2
src/java/org/apache/cassandra/streaming/management/StreamSummaryCompositeData.java:2
src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java:1
src/java/org/apache/cassandra/db/compaction/Scrubber.java:1
src/java/org/apache/cassandra/db/compaction/Verifier.java:1
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:1
src/java/org/apache/cassandra/db/compaction/Upgrader.java:1
src/java/org/apache/cassandra/io/compress/CompressionMetadata.java:1
src/java/org/apache/cassandra/streaming/management/SessionCompleteEventCompositeData.java:2
src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java:1
src/java/org/apache/cassandra/io/sstable/ISSTableScanner.java:1
src/java/org/apache/cassandra/streaming/management/SessionInfoCompositeData.java:3
src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java:1
{code}
I don't know if we want to remove all usages but we should at least check author's intention
for each usage and refactor if needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message