cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14206) Python 3 LooseVersion breaks compatibility with Python 2.7 LooseVersion
Date Thu, 01 Feb 2018 18:18:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349035#comment-16349035
] 

Sam Tunnicliffe commented on CASSANDRA-14206:
---------------------------------------------

Running the new dtests against 3.11 results in a bunch of failures at the moment. Some are
legit failures and some are problems with the tests. I've got a branch where I'm pushing fixes
to the test plumbing (including the attached diff): https://github.com/beobal/cassandra-dtest/tree/14206

> Python 3 LooseVersion breaks compatibility with Python 2.7 LooseVersion
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14206
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14206
>             Project: Cassandra
>          Issue Type: Test
>          Components: Testing
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>            Priority: Major
>         Attachments: loose_version.diff
>
>
> In 2.7 it uses the cmp built-in to compare the list of version components which accepts
comparisons of strings and integers. In python 3 it manually compares each using <, ==,
and > which can fail if the the types don't match.
> Switch to using our own comparison function that preserves the old behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message