cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14153) BloomFilterTest generates un-deleted test file
Date Wed, 10 Jan 2018 13:46:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320256#comment-16320256
] 

Jason Brown commented on CASSANDRA-14153:
-----------------------------------------

As an alternative to calling {{file#delete()}} and using a {{try/catch}} block, I created
a new function {{FileUtils#createDeletableTempFile()}}, which calls {{File#deleteOnExit}}
on the temp file. This way puts the cleanup logic in a one place. wdyt?

||14153||
|[branch|https://github.com/jasobrown/cassandra/tree/14153]|
|[utests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14153]|


> BloomFilterTest generates un-deleted test file
> ----------------------------------------------
>
>                 Key: CASSANDRA-14153
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14153
>             Project: Cassandra
>          Issue Type: Test
>          Components: Testing
>            Reporter: Jay Zhuang
>            Assignee: Jay Zhuang
>            Priority: Minor
>              Labels: testing
>
> https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/utils/BloomFilterTest.java#L196



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message