cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7816) Duplicate DOWN/UP Events Pushed with Native Protocol
Date Mon, 22 Jan 2018 23:00:02 GMT


ASF GitHub Bot commented on CASSANDRA-7816:

Github user aweisberg commented on a diff in the pull request:
    --- Diff: src/java/org/apache/cassandra/transport/ ---
    @@ -454,51 +455,32 @@ public static LatestEvent forTopologyChange(Event.TopologyChange.Change
             // We keep track of the latest status change events we have sent to avoid sending
             // since StorageService may send duplicate notifications (CASSANDRA-7816, CASSANDRA-8236,
    -        private final Map<InetAddress, LatestEvent> latestEvents = new ConcurrentHashMap<>();
    +        private final Map<InetAddressAndPort, LatestEvent> latestEvents = new ConcurrentHashMap<>();
             // We also want to delay delivering a NEW_NODE notification until the new node
has set its RPC ready
             // state. This tracks the endpoints which have joined, but not yet signalled
they're ready for clients
    -        private final Set<InetAddress> endpointsPendingJoinedNotification = ConcurrentHashMap.newKeySet();
    -        private static final InetAddress bindAll;
    --- End diff --
    I looked up the JIRA and it's not necessary anymore. The comment says 
                    // Note that after all nodes are running a version that includes CASSANDRA-5899,
rpcAddress should
                    // never be, so this can eventually be removed.
    So we can never hit that path anyway. I think it was useful when introduced, but it's
not anymore.

> Duplicate DOWN/UP Events Pushed with Native Protocol
> ----------------------------------------------------
>                 Key: CASSANDRA-7816
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Michael Penick
>            Assignee: Stefania
>            Priority: Minor
>             Fix For: 2.0.15, 2.1.5
>         Attachments: 7816-v2.0.txt, tcpdump_repeating_status_change.txt, trunk-7816.txt
> Added "MOVED_NODE" as a possible type of topology change and also specified that it is
possible to receive the same event multiple times.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message