Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 26 Dec 2017 12:56:02 +0000 (UTC)
From: "Paulo Motta (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13121921.1512050437000.532563.1514292962473@Atlassian.JIRA>
In-Reply-To: <JIRA.13121921.1512050437000@Atlassian.JIRA>
References: <JIRA.13121921.1512050437000@Atlassian.JIRA> <JIRA.13121921.1512050437900@jira-lw-us.apache.org>
Subject: [jira] [Updated] (CASSANDRA-14083) Avoid invalidating disk
 boundaries unnecessarily
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 26 Dec 2017 12:56:14 -0000


     [ https://issues.apache.org/jira/browse/CASSANDRA-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paulo Motta updated CASSANDRA-14083:
------------------------------------
       Resolution: Fixed
    Fix Version/s: 4.0
                   3.11.2
           Status: Resolved  (was: Ready to Commit)

> Avoid invalidating disk boundaries unnecessarily
> ------------------------------------------------
>
>                 Key: CASSANDRA-14083
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14083
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>             Fix For: 3.11.2, 4.0
>
>         Attachments: 3.11-14083-dtest.png, 3.11-14083-testall.png, trunk-14083-dtest.png, trunk-14083-testall.png
>
>
> We currently invalidate disk boundaries whenever [instantiating a new replication strategy|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L359], but this is done whenever [updating keyspace settings|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L187]. 
> Computing new boundaries is expensive and unnecessarily invalidating them will cause {{DiskBoundaries}} consumers to also invalidate their work unnecessarily. For instance, after CASSANDRA-13948 the {{CompactionStrategyManager}} will reload all compaction strategies when the boundaries are invalidated.
> In this case, we should only invalidate the disk boundaries when the replication settings change to avoid doing unnecessary work.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org