Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 1 Dec 2017 19:08:00 +0000 (UTC)
From: "Stefan Podkowinski (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13119377.1510964775000.366966.1512155280361@Atlassian.JIRA>
In-Reply-To: <JIRA.13119377.1510964775000@Atlassian.JIRA>
References: <JIRA.13119377.1510964775000@Atlassian.JIRA> <JIRA.13119377.1510964775335@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-14059) Root logging formatter broken
 in dtests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 01 Dec 2017 19:08:04 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274789#comment-16274789 ] 

Stefan Podkowinski commented on CASSANDRA-14059:
------------------------------------------------

+1

> Root logging formatter broken in dtests
> ---------------------------------------
>
>                 Key: CASSANDRA-14059
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14059
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Joel Knighton
>            Assignee: Joel Knighton
>            Priority: Minor
>
> Since the ccm dependency in dtest was bumped to {{3.1.0}} in {{7cc06a086f89ed76499837558ff263d84337acba}}, when dtests are run with --nologcapture, errors of the following form are printed:
> {code}
> Traceback (most recent call last):
>   File "/usr/lib64/python2.7/logging/__init__.py", line 861, in emit
>     msg = self.format(record)
>   File "/usr/lib64/python2.7/logging/__init__.py", line 734, in format
>     return fmt.format(record)
>   File "/usr/lib64/python2.7/logging/__init__.py", line 469, in format
>     s = self._fmt % record.__dict__
> KeyError: 'current_test'
> Logged from file dtest.py, line 485
> {code}
> This is because CCM no longer installs a basic root logger configuration, which is probably a more correct behavior than what it did prior to this change. Now, dtest installs its own basic root logger configuration which writes to 'dtest.log' using the formatter {{'%(asctime)s,%(msecs)d %(name)s %(current_test)s %(levelname)s %(message)s'}}. This means that anything logging a message must provide the current_test key in its extras map. The dtest {{debug}} and {{warning}} functions do this, but logging from dependencies doesn't, producing these {{KeyError}} s. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org