Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4360F200D5C for ; Fri, 1 Dec 2017 01:29:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 41FDF160C04; Fri, 1 Dec 2017 00:29:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 89003160C01 for ; Fri, 1 Dec 2017 01:29:03 +0100 (CET) Received: (qmail 2765 invoked by uid 500); 1 Dec 2017 00:29:02 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 2754 invoked by uid 99); 1 Dec 2017 00:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Dec 2017 00:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F405118071A for ; Fri, 1 Dec 2017 00:29:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 63-Pe9a_aC_S for ; Fri, 1 Dec 2017 00:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F12555F39D for ; Fri, 1 Dec 2017 00:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 826A1E0D6A for ; Fri, 1 Dec 2017 00:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38A1221065 for ; Fri, 1 Dec 2017 00:29:00 +0000 (UTC) Date: Fri, 1 Dec 2017 00:29:00 +0000 (UTC) From: "Kurt Greaves (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-13976) introduce max_hint_window_in_min, deprecate max_hint_window_in_ms MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Dec 2017 00:29:04 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273722#comment-16273722 ] Kurt Greaves commented on CASSANDRA-13976: ------------------------------------------ Not necessary to support both, just convert the minute value to ms if the {{max_hint_window_in_min}} property exists, otherwise use the {{max_hint_window_in_ms}} value or default if neither exist. TBH I don't think we should ever completely get rid of the ms config option as I wouldn't be surprised if there are tests relying on setting it to <1min, but we could remove it from the default yaml and add in the minute based config instead. > introduce max_hint_window_in_min, deprecate max_hint_window_in_ms > ----------------------------------------------------------------- > > Key: CASSANDRA-13976 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13976 > Project: Cassandra > Issue Type: Improvement > Reporter: Jon Haddad > Assignee: Kirk True > Priority: Minor > Labels: lhf > Fix For: 4.0 > > > Milliseconds is unnecessarily precise. At most, minutes would be used. Config in 4.0 should default to a minute granularity, but if the max_hint_window_in_min isn't set should fall back on max_hint_window_in_ms and emit a warning. > max_hint_window_in_min: 180 # new default, still at 3 hours. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org