cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-14108) Improve commit log chain marker updating
Date Thu, 14 Dec 2017 03:56:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Brown resolved CASSANDRA-14108.
-------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 4.x)
                   4.0

committed as sha {{db788fe860dfd69f06ab97ae35fa67fcf2517b6d}}. Thanks [~aweisberg] and [~beobal].

> Improve commit log chain marker updating
> ----------------------------------------
>
>                 Key: CASSANDRA-14108
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14108
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>             Fix For: 3.0.16, 3.11.2, 4.0
>
>
> CASSANDRA-13987 addressed the commit log behavior change that was introduced with CASSANDRA-3578.
After that patch was committed, [~aweisberg] did his own review and found a bug as well as
having some concerns about the configuration. He and I discussed offline, and agreed on some
improvements. 
> Instead of requiring users to configure a deep, dark implementation detail like the commit
log chained markers (via {{commitlog_marker_period_in_ms}} in the yaml), we decided it is
best to eliminate thew configuration and always update the chained markers (when in periodic
mode). 
> The bug [~aweisberg] found was when the chained marker update is not a value that evenly
divides into the periodic sync mode value, we would not sync in an expected manner. For example
if the marker interval is 9 seconds, and the sync interval is 10 seconds, we would update
the markers at time9, but we would then sleep for another 9 seconds, and when we wake up at
time18, it is then that we flush - 8 seconds later than we should have. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message