cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14081) Remove AbstractCompactionStrategy.replaceFlushed
Date Fri, 01 Dec 2017 13:47:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274416#comment-16274416
] 

Paulo Motta commented on CASSANDRA-14081:
-----------------------------------------

bq.  should we remove ACS#getMemtableReservedSize() and ACS#isAffectedByMeteredFlusher() at
the same time?

Agreed. In the same spirit I removed the deprecated methods {{enable}}, {{disabled}} and {{shouldBeEnabled}}
from {{AbstractCompactionStrategy}}, do you think this is OK?

Final patch [here|https://github.com/pauloricardomg/cassandra/tree/trunk-14081]. CI looks
good (just some [unrelated dtest failures|https://issues.apache.org/jira/secure/attachment/12900220/dtest14081.png])

> Remove AbstractCompactionStrategy.replaceFlushed
> ------------------------------------------------
>
>                 Key: CASSANDRA-14081
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14081
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Minor
>         Attachments: dtest14081.png
>
>
> I didn't find a reason for why we need to send flush notifications from CFs -> CSM
-> Tracker, if we can bypass the CSM and send directly to the tracker from the CFS (and
handle it on the CSM via {{SSTableAddedNotification}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message